fix: Check for expected error types, rethrow unknown #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2157 +/- ##
==========================================
+ Coverage 85.73% 87.51% +1.78%
==========================================
Files 91 133 +42
Lines 3785 7050 +3265
Branches 1220 1669 +449
==========================================
+ Hits 3245 6170 +2925
- Misses 454 785 +331
- Partials 86 95 +9 ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
fix/missing-error-key
branch
from
ce26d09 to
ebd86bf
Compare
Collaborator
Author
|
@rwblair This should go in before a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #2130. @rwblair is working on fixing the real error.